[onert] Share tensors memory for designated operands #14384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the tensors memory management to handle sharing memory buffers. It means that more that one tensor can indicate the same buffer. It is determined by operands index map calculated in the previous step. Note that cases like sharing memory from constant tensors requires additional checks. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]
ragmani
reviewed
Dec 3, 2024
runtime/onert/core/include/backend/basic/BackendContextHelpers.h
Outdated
Show resolved
Hide resolved
ragmani
reviewed
Dec 11, 2024
runtime/onert/core/include/backend/basic/BackendContextHelpers.h
Outdated
Show resolved
Hide resolved
runtime/onert/core/include/backend/basic/BackendContextHelpers.h
Outdated
Show resolved
Hide resolved
runtime/onert/core/include/backend/basic/BackendContextHelpers.h
Outdated
Show resolved
Hide resolved
ragmani
reviewed
Dec 11, 2024
ragmani
previously approved these changes
Dec 12, 2024
ragmani
approved these changes
Dec 12, 2024
|
@zetwhite if you find a moment please take a look ;-) |
zetwhite
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the tensors memory management to handle sharing memory buffers. It means that more that one tensor can indicate the same buffer. It is determined by operands index map calculated in the previous step. Note that cases like sharing memory from constant tensors requires additional checks.
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]
Draft: #14057