Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onert/odc] Auto-compilation. Input/output buffers in Execution #14383

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[onert/odc] Auto-compilation. Input/output buffers in Execution #14383

merged 1 commit into from
Dec 4, 2024

Conversation

Torrero
Copy link
Contributor

@Torrero Torrero commented Nov 29, 2024

This PR for odc:auto-compilation introduces OdcInfo structure and input/output buffers in Execution.

For Issue.
From Draft.

ONE-DCO-1.0-Signed-off-by: Evgenii Maltsev [email protected]

@Torrero Torrero force-pushed the onert_odc_autocompilation_execution_changes branch from cf0fdb2 to d3f92a4 Compare November 29, 2024 18:09
@hseok-oh
Copy link
Contributor

hseok-oh commented Dec 2, 2024 •
edited
Loading

Looks good for input/output buffer getter.
BTW, what is purpose of OdcInfo? Representation of model loading status? or Input model type of ODC?

@Torrero
Copy link
Contributor Author

Torrero commented Dec 2, 2024

Looks good for input/output buffer getter. BTW, what is purpose of OdcInfo? Representation of model loading status? or Input model type of ODC?

@hseok-oh Purpose of OdcInfo is for representation of model loading status (as for quantized as for compiled model). It's used in the run_with_auto_compilation method for providing loading status and checking the code generation status.

@hseok-oh
Copy link
Contributor

hseok-oh commented Dec 2, 2024

@hseok-oh Purpose of OdcInfo is for representation of model loading status (as for quantized as for compiled model). It's used in the run_with_auto_compilation method for providing loading status and checking the code generation status.

Then that seems independent with ODC. Is that used in ODC? Otherwise, it may be better to handled in session (in nnfw_api_internal), IMHO.

@Torrero
Copy link
Contributor Author

Torrero commented Dec 2, 2024 •
edited
Loading

@hseok-oh Purpose of OdcInfo is for representation of model loading status (as for quantized as for compiled model). It's used in the run_with_auto_compilation method for providing loading status and checking the code generation status.

Then that seems independent with ODC. Is that used in ODC? Otherwise, it may be better to handled in session (in nnfw_api_internal), IMHO.

@hseok-oh you are right, this structure is not used in ODC, it's used in nnfw_session.
I deleted OdcInfo structure and added AutoCompilationState to nnwf_session in the draft and changed the usage in run_with_auto_compilation

@Torrero
[onert/odc] Auto-compilation. OdcInfo and input/output buffers in Exe…
d6974be 
…cution

This PR for `odc:auto-compilation` introduces OdcInfo structure and input/output buffers in Execution.
For [Issue]( Samsung#13288).
From [Draft](Samsung#13530).

ONE-DCO-1.0-Signed-off-by: Evgenii Maltsev [email protected]
@Torrero Torrero force-pushed the onert_odc_autocompilation_execution_changes branch from d3f92a4 to d6974be Compare December 2, 2024 17:10
@Torrero
Copy link
Contributor Author

Torrero commented Dec 2, 2024

Rebased this PR and deleted OdcInfo structure

hseok-oh
hseok-oh approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stamalakhov
stamalakhov approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@stamalakhov stamalakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Torrero Torrero changed the title [onert/odc] Auto-compilation. OdcInfo and input/output buffers in Execution [onert/odc] Auto-compilation. Input/output buffers in Execution Dec 3, 2024
SlavikMIPT
SlavikMIPT approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 240bda7 into Samsung:master Dec 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stamalakhov stamalakhov stamalakhov approved these changes

@hseok-oh hseok-oh hseok-oh approved these changes

@SlavikMIPT SlavikMIPT SlavikMIPT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Torrero @hseok-oh @SlavikMIPT @stamalakhov