Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onert/python] Update setup parameters #14362

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[onert/python] Update setup parameters #14362

merged 1 commit into from
Nov 26, 2024

Conversation

hseok-oh
Copy link
Contributor

This commit updates setup parameters.

  • Update description: nnfw -> onert
  • Add URL
  • Add license
  • Add 'has_ext_modules': update wheel naming automatically for wheel installation
  • Add package dependency

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]

@hseok-oh
[onert/python] Update setup parameters
4f0dccc 
This commit updates setup parameters.
- Update description: nnfw -> onert
- Add URL
- Add license
- Add 'has_ext_modules':  update wheel naming automatically for wheel installation
- Add package dependency

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Nov 25, 2024
@hseok-oh hseok-oh requested a review from a team November 25, 2024 07:53
@hseok-oh
Copy link
Contributor Author

hseok-oh commented Nov 25, 2024 •
edited
Loading

Wheel file name for python 3.8: onert-0.1.0.dev24112500-py3-none-manylinux_2_31_armv7l.whl -> onert-0.1.0.dev24112500-cp38-cp38-manylinux_2_31_armv7l.whl
For python 3.10 (ubuntu 22.04): onert-0.1.0.dev24112500-cp310-cp310-manylinux_2_31_armv7l.whl

@chunseoklee
Copy link
Contributor

@hseok-oh Based on https://peps.python.org/pep-0491/#file-name-convention, our cp38 for ABI tag is proper ?

@hseok-oh
Copy link
Contributor Author

hseok-oh commented Nov 26, 2024 •
edited
Loading

@chunseoklee We need to make wheel for each python version (currently 3.8 ~ 3.12). To make each python version, we need to make build CI to using each python version and make wheel on each environment. Then wheel file's python and API tag on each environment will be changed automatically (cp38 ~ cp312).

@hseok-oh hseok-oh merged commit 845e26f into Samsung:master Nov 26, 2024
9 checks passed
@hseok-oh hseok-oh deleted the python_setup_args branch November 26, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunseoklee chunseoklee chunseoklee approved these changes

Assignees
No one assigned
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hseok-oh @chunseoklee