[Draft][onert] Optimize FullyConnected #14335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds ggml worker ONE-DCO-1.0-Signed-off-by: youngsik kim <[email protected]>
This commit is for optimizing bmm from sg5.lee ONE-DCO-1.0-Signed-off-by: youngsik kim <[email protected]>
This commit restores o2024 ggml ONE-DCO-1.0-Signed-off-by: youngsik kim <[email protected]>
ys44kim
commented
Nov 22, 2024
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #define GGML_COMMON_DECL_C |
There was a problem hiding this comment.
o2024 ggml is restored,
the latest ggml has a performance degradation of 5% compared to the o2024 version
refer to glistening
|
|
||
| ggml_setup_op_has_task_pass(); | ||
|
|
||
| ggml_worker_init(); |
There was a problem hiding this comment.
create a thread in ggml_init, and the corresponding thread is waiting for work
| #ifdef GGML_TRACE | ||
| for(int i = 0; i < TRACE_THREAD_MAX_N; i++) | ||
| { | ||
| chrome_trace_init(&trace_scope[i], i); |
There was a problem hiding this comment.
add trace for profiling ggml op
| }; | ||
|
|
||
| ggml_worker_submit(ggml_graph_compute_thread, &workers[j]); |
There was a problem hiding this comment.
- submit work with ggml_graph_computer_thread
- transmits the signal to the multi thread.
- the thread executes ggml_graph_computer_thread after wakeup.
|
I do not merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test pr for fully connected optimization.
and there is no plan to merge this PR.
ONE-DCO-1.0-Signed-off-by: youngsik kim [email protected]