Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circlechef] Support mx data type #14304

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jinevening
Copy link
Contributor

This introduces MXFP4 and MXINT8.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]


Related to: #14293
Draft PR: #14294

This introduces MXFP4 and MXINT8.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -14,6 +14,8 @@ package circlechef;

// This enum value corresponds to TensorType in TensorFlow Lite schema
Copy link
Contributor

@glistening glistening Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) This comment is not correct any longer after UINT4, MXFP4, and MXINT8.

Copy link
Contributor Author

@jinevening jinevening Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this comment in another PR. :)

Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinevening jinevening merged commit 10d3ad3 into Samsung:master Nov 5, 2024
8 checks passed
@jinevening jinevening deleted the circlechef/mx branch November 5, 2024 13:01
BLee-bot pushed a commit to BLee-bot/ONE that referenced this pull request Nov 6, 2024
This introduces MXFP4 and MXINT8.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants