-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[record-hessian] Introduce HessianObserver. #14292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce hessian observer. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
seanshpark
reviewed
Nov 4, 2024
compiler/record-hessian/include/record-hessian/HessianObserver.h
Outdated
Show resolved
Hide resolved
seanshpark
reviewed
Nov 4, 2024
seanshpark
reviewed
Nov 4, 2024
seanshpark
reviewed
Nov 4, 2024
seanshpark
reviewed
Nov 4, 2024
Change local variable naming and remove redundant includes. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
seanshpark
reviewed
Nov 4, 2024
seanshpark
reviewed
Nov 4, 2024
Add header for unique_ptr, change assert to throw. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Remove useless line, and add more headers. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
seanshpark
reviewed
Nov 4, 2024
seanshpark
reviewed
Nov 4, 2024
Add assertion check for node and tensor pointer. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
jinevening
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seanshpark
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce HessianObserver.
ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]
Related Issue : #13480
Draft PR: #13585