Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[record-hessian] Introduce HessianObserver. #14292

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

BLee-bot
Copy link
Contributor

@BLee-bot BLee-bot commented Nov 4, 2024

This PR introduce HessianObserver.

ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]

Related Issue : #13480
Draft PR: #13585

This commit introduce hessian observer.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Change local variable naming and remove redundant includes.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add header for unique_ptr, change assert to throw.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Remove useless line, and add more headers.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Add assertion check for node and tensor pointer.

ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
@seanshpark seanshpark requested a review from a team November 4, 2024 07:57
Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 85bcba8 into Samsung:master Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants