Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angkor] Minor doc fix #14268

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[angkor] Minor doc fix #14268

merged 1 commit into from
Oct 28, 2024

Conversation

pfusik
Copy link
Contributor

@pfusik pfusik commented Oct 28, 2024

This corrects a typo and formatting.

ONE-DCO-1.0-Signed-off-by: Piotr Fusik [email protected]

This corrects a typo and formatting.

ONE-DCO-1.0-Signed-off-by: Piotr Fusik <[email protected]>
@pfusik
Copy link
Contributor Author

pfusik commented Oct 28, 2024

Splitting #12695 to multiple PRs as requested by @seanshpark

@@ -2,11 +2,11 @@

## Purpose

_angkor_ is a `nncc` core library
_angkor_ is an `nncc` core library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why an ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found that nncc is pronounced like en en see see so it would be better with an , not a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly the rule for "a" vs "an" in English. It only matters how you pronounce the following word, not how you spell it.
For example: an XML ("eks em el") vs a XAML ("a zammel").

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 1a3007c into Samsung:master Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants