Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fme-detect] Support one more forwardable successors #14241

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mhs4670go
Copy link
Contributor

This commit supports one more forwardable successors.

ONE-DCO-1.0-Signed-off-by: seongwoo [email protected]

This commit supports one more forwardable successors.

ONE-DCO-1.0-Signed-off-by: seongwoo <[email protected]>
@mhs4670go mhs4670go added the PR/ready for review It is ready to review. Please review it. label Oct 21, 2024
@mhs4670go mhs4670go requested a review from a team October 21, 2024 15:44
jinevening

This comment was marked as outdated.

Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, which model will benefit from this change?

@mhs4670go
Copy link
Contributor Author

@jinevening

BTW, which model will benefit from this change?

Cartoongan has a pattern 'InstNorm - LeakyRelu - Pad - Conv' where front is InstNorm and back is Conv. Before this PR, a pattern finder only can forward one node when it finds pattern. This PR makes it possible to forward up to two nodes. It's not a bit generic though. Please let me tag this job a TODO:)

@jinevening jinevening merged commit ba739ad into Samsung:master Oct 22, 2024
8 checks passed
@mhs4670go mhs4670go deleted the f4 branch October 22, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants