[onert/cpu] [Reshape, ExpandDims] Avoid copying memory if possible #14229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit copying memory only if output buffer is different from input buffer. It they are equal it means that input and output tensors share the same memory. It is applicable for Reshape and ExpandDims operations. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]
seockho-kim
reviewed
Oct 24, 2024
| size_t count = _input->total_size(); | ||
| memcpy(_output->buffer(), _input->buffer(), count); | ||
| // output buffer equals to input buffer means that copy is not needed | ||
| if (_output->buffer() != _input->buffer()) |
There was a problem hiding this comment.
I have a question.
Did you have a case that input and output buffer are same?
For memcpy(), src and dest memory area must not overlap, otherwise, its behavior is undefined.
There was a problem hiding this comment.
Note that this change is a part of bigger issue implemented in #14057. In this draft I am changing tensor allocation mechanism to share memory memory between input and output tensors of Reshape/ExpandDims/Squeeze. In other words different tensors can indicate the same buffers (it requires additional handing of such memory management).
There was a problem hiding this comment.
I've followed the draft and issue and understood.
Thanks for the explanation :)
|
I'll merge this because it is too delayed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit copying memory only if output buffer is different from input buffer. It they are equal it means that input and output tensors share the same memory. It is applicable for Reshape and ExpandDims operations.
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]
Draft: #14057