Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests/nnfw_api] Add RmsNorm test cases for nnfw API #14175

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

seockho-kim
Copy link
Contributor

This commit adds RmsNorm test cases for nnfw API.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]

issue: #14089
draft: #14088

@seockho-kim seockho-kim requested a review from a team October 8, 2024 01:27
@ragmani
Copy link
Contributor

ragmani commented Oct 8, 2024

The error message on CI,

[2024-10-08T01:47:55.564Z] [ RUN      ] GenModelTest.OneOp_RmsNorm

[2024-10-08T01:47:55.564Z] Error during model loading : Unsupported operation: RMS_NORM

[2024-10-08T01:47:55.564Z] /opt/jenkins_agent/workspace/nnfw/master/pr-onert-cross-release/tests/nnfw_api/lib/GenModelTest.h:309: Failure

[2024-10-08T01:47:55.564Z] Expected equality of these values:

[2024-10-08T01:47:55.564Z]   (model_load_result)

[2024-10-08T01:47:55.564Z]     Which is: 1

[2024-10-08T01:47:55.564Z]   NNFW_STATUS_NO_ERROR

[2024-10-08T01:47:55.564Z]     Which is: 0

[2024-10-08T01:47:55.564Z] [  FAILED  ] GenModelTest.OneOp_RmsNorm (0 ms)

[2024-10-08T01:47:55.564Z] [ RUN      ] GenModelTest.neg_OneOp_RmsNorm_InvalidShape

[2024-10-08T01:47:55.564Z] Error during model loading : Unsupported operation: RMS_NORM

[2024-10-08T01:47:55.564Z] /opt/jenkins_agent/workspace/nnfw/master/pr-onert-cross-release/tests/nnfw_api/lib/GenModelTest.h:309: Failure

[2024-10-08T01:47:55.564Z] Expected equality of these values:

[2024-10-08T01:47:55.564Z]   (model_load_result)

[2024-10-08T01:47:55.564Z]     Which is: 1

[2024-10-08T01:47:55.564Z]   NNFW_STATUS_NO_ERROR

[2024-10-08T01:47:55.564Z]     Which is: 0

[2024-10-08T01:47:55.564Z] [  FAILED  ] GenModelTest.neg_OneOp_RmsNorm_InvalidShape (0 ms)

@seockho-kim
Copy link
Contributor Author

The error message on CI,
.....
[2024-10-08T01:47:55.564Z] [ FAILED ] GenModelTest.neg_OneOp_RmsNorm_InvalidShape (0 ms)

I'll rebase after other related PRs are merged, then it will be fixed. :)

This commit adds RmsNorm test cases for nnfw API.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
@seockho-kim seockho-kim force-pushed the test_nnfwapi_rmsnorm branch from 75cdd2b to 4a3ed17 Compare October 8, 2024 04:57
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit de50b13 into Samsung:master Oct 8, 2024
9 checks passed
@seockho-kim seockho-kim deleted the test_nnfwapi_rmsnorm branch October 8, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants