Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Add lifetime enum to LayerScopeTensor #13861

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[onert] Add lifetime enum to LayerScopeTensor #13861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion runtime/onert/core/include/backend/train/LayerScopeTensor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ namespace backend
namespace train
{

enum class LayerScopeTensorLifeTime : unsigned char
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(out of my curiosity)
Why do you set a type for this enumaration class? What is the advantages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyoungyun

AFAIK, if we didn't set a type(enum-base) for enum class, the enum element takes 4 bytes by default.
In this case, I'd like to reduce the size of enum element. (default : 4bytes -> unsigned char 1bytes)

{
BACKWARD, // alive during backward()
FORWARD_TO_BACKWARD, // alive from forward() to backward()
};
Comment on lines +29 to +33
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lifetime info will be used to plan and allocate a buffer for LayerScopeTensor.


// LayerScopeTensor is a tensor that is not shown in graph but required by each layer.
// It is accessed within one operation layer.
class LayerScopeTensor final : public basic::Tensor
Expand All @@ -34,10 +40,22 @@ class LayerScopeTensor final : public basic::Tensor
LayerScopeTensor() = delete;

public:
LayerScopeTensor(const ir::OperandInfo &info) : basic::Tensor(info, nullptr)
LayerScopeTensor(const ir::OperandInfo &info, LayerScopeTensorLifeTime lt)
: basic::Tensor(info, nullptr), _lifetime(lt)
{
// DO NOTHING
}

LayerScopeTensor(const ir::OperandInfo &info)
: basic::Tensor(info, nullptr), _lifetime(LayerScopeTensorLifeTime::BACKWARD)
{
// DO NOTHING
}

LayerScopeTensorLifeTime lifetime() const { return _lifetime; }

private:
LayerScopeTensorLifeTime _lifetime;
};

} // namespace train
Expand Down