Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Remove layout in ITensor #13839

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

hseok-oh
Copy link
Contributor

This commit removes layout access from ITensor and derived classes.
Tensor classes for external buffer (IOTensor, UserTensor, EdgeTensor) and unittest remains layout information.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]


Draft: #13797
Related issue: #12130 #13494

This commit removes layout access from ITensor and derived classes.
Tensor classes for external buffer (IOTensor, UserTensor, EdgeTensor) and unittest remains layout information.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Aug 29, 2024
@hseok-oh hseok-oh requested a review from a team August 29, 2024 07:16
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun requested a review from a team August 29, 2024 09:59
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 42ec5c9 into Samsung:master Aug 29, 2024
9 checks passed
@hseok-oh hseok-oh deleted the remove_itensor_layout branch August 29, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants