[luci/service] Migrate Quantize shape inference rule to sinf::Algorithm #13812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyeong8139
added
PR/ready for review
kyeong8139
requested review from
seanshpark,
jinevening,
zetwhite and
shs-park
seanshpark
reviewed
Aug 28, 2024
| ASSERT_EQ(0, shape.dim(2).value()); | ||
| ASSERT_EQ(4, shape.dim(3).value()); | ||
|
|
||
| quantize.drop(); |
There was a problem hiding this comment.
have you checked with this drop?
seanshpark
reviewed
Aug 28, 2024
|
|
||
| ASSERT_FALSE(shape_inf_rule.infer(&quantize, shape)); | ||
|
|
||
| quantize.drop(); |
seanshpark
reviewed
Aug 28, 2024
zetwhite
reviewed
Aug 28, 2024
|
Also, plz update your commit ( 24ffc63) title.
|
kyeong8139
force-pushed
the
luci/quantize
branch
from
24ffc63 to
bda5613
Compare
seanshpark
reviewed
Aug 29, 2024
| @@ -24,4 +27,11 @@ luci::CircleNode *CloneNodeLet<CN::OPQR>::visit(const luci::CircleQuantize *) | |||
| return _graph->nodes()->create<luci::CircleQuantize>(); | |||
| } | |||
|
|
|||
| loco::TensorShape sinf::Algorithm::visit(const luci::CircleQuantize *node) | |||
There was a problem hiding this comment.
plz revise this like #13810
There was a problem hiding this comment.
I applied this to compiler/luci/service/src/Nodes/CircleQuantize.cpp
kyeong8139
force-pushed
the
luci/quantize
branch
3 times, most recently
from
a7387bd to
e3d5482
Compare
This commit Migrate Quantize shape inference rule to sinf::Algorithm. ONE-DCO-1.0-Signed-off-by: kyeong8139 <[email protected]>
This commit modify tests without drop. ONE-DCO-1.0-Signed-off-by: kyeong8139 <[email protected]>
This commit use namespace. ONE-DCO-1.0-Signed-off-by: kyeong8139 <[email protected]>
kyeong8139
force-pushed
the
luci/quantize
branch
from
e3d5482 to
51bdff7
Compare
jinevening
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing dynamic shape inference, the original quantize operation successfully handles it.
I have migrated the inference code and modified shape_get function to circle_shape
Related to: #13697
draft: #13779
first-pr: #13794 (I fail to modify first commit message.. so I create new pull-request)