Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/service] Support MUL dynamic shape inference #13795

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

qsunki
Copy link
Contributor

@qsunki qsunki commented Aug 28, 2024

This supports dynamic shape inference for MUL.

ONE-DCO-1.0-Signed-off-by: sunki [email protected]


Related to: #13697
Draft PR: #13777

This supports dynamic shape inference for MUL.

ONE-DCO-1.0-Signed-off-by: sunki <[email protected]>
@qsunki qsunki added PR/ready for review It is ready to review. Please review it. SSAFY labels Aug 28, 2024
seanshpark
seanshpark previously approved these changes Aug 28, 2024
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zetwhite
zetwhite previously approved these changes Aug 28, 2024
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This adds 'sinf namespace' for CircleMul Node's sinf::Algorithm::visit() function.

ONE-DCO-1.0-Signed-off-by: sunki <[email protected]>
@qsunki qsunki dismissed stale reviews from zetwhite and seanshpark via 55eb8a8 August 28, 2024 08:56
@qsunki
Copy link
Contributor Author

qsunki commented Aug 28, 2024

I have checked this comment #13780 (review) and have applied it to the current PR.

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark seanshpark merged commit cb5f98d into Samsung:master Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it. SSAFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants