[onert] Revisit DepthwiseConv2D nnfw_api test #13559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyoungyun
force-pushed
the
onert/nnfw_api_dconv_tst
branch
from
e86003b to
8fb200c
Compare
ragmani
reviewed
Jul 30, 2024
This commit renames test cases to be simple and adds test cases related to Bias and Multiplier. ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
jyoungyun
force-pushed
the
onert/nnfw_api_dconv_tst
branch
from
8fb200c to
0adcc93
Compare
hseok-oh
reviewed
Jul 31, 2024
Comment on lines
22
to
23
| std::vector<float> weight_data{1.0f, 2.0f, 3.0f, 4.0f, -9.0f, 10.0f, -11.0f, 12.0f, | ||
| 5.0f, 6.0f, 7.0f, 8.0f, 13.0f, -14.0f, 15.0f, -16}; |
There was a problem hiding this comment.
Why weight shape is {1, 2, 2, 2} and data size is 16?
Suggested change
| std::vector<float> weight_data{1.0f, 2.0f, 3.0f, 4.0f, -9.0f, 10.0f, -11.0f, 12.0f, | |
| 5.0f, 6.0f, 7.0f, 8.0f, 13.0f, -14.0f, 15.0f, -16}; | |
| std::vector<float> weight_data{1.0f, 2.0f, 3.0f, 4.0f, -9.0f, 10.0f, -11.0f, 12.0f}; |
|
@jyoungyun Please fix format |
ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
jyoungyun
force-pushed
the
onert/nnfw_api_dconv_tst
branch
from
85a7394 to
fe93805
Compare
hseok-oh
approved these changes
Aug 1, 2024
ragmani
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames test cases to be simple and adds test cases related to Bias and Multiplier.
ONE-DCO-1.0-Signed-off-by: Jiyoung Yun [email protected]