[luci/pass] Canonicalize PadV2 paddings #13542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable Canonicalize PadV2 paddings dtype. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
shs-park
approved these changes
Jul 29, 2024
| return true; | ||
| } | ||
|
|
||
| // TODO merge both paddings_to_s32 with template |
There was a problem hiding this comment.
May I ask what the meaning of both paddings in this comment is?
There was a problem hiding this comment.
there are two paddings_to_s32(), one for Pad and another for PadV2.
changes in this PR for PadV2 is copied from Pad.
jyoungyun
pushed a commit
to jyoungyun/ONE
that referenced
this pull request
Jul 30, 2024
This will enable Canonicalize PadV2 paddings dtype. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable Canonicalize PadV2 paddings dtype.