Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Set dilation factor in DepthwiseConv train kernel #13540

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jyoungyun
Copy link
Contributor

This commit sets dilation factor in DepthwiseConv train kernel. The DepthwiseConv train kernel does not support dilation value other than 1. It adds assertion to check the supported dilation value.

ONE-DCO-1.0-Signed-off-by: Jiyoung Yun [email protected]

This commit sets dilation factor in DepthwiseConv train kernel.
The DepthwiseConv train kernel does not support dilation value other
than 1. It adds assertion to check the supported dilation value.

ONE-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
@jyoungyun jyoungyun added the PR/ready for review It is ready to review. Please review it. label Jul 29, 2024
@jyoungyun jyoungyun requested a review from a team July 29, 2024 06:08
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zetwhite zetwhite requested a review from a team July 29, 2024 06:29
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit b527821 into Samsung:master Jul 29, 2024
9 checks passed
@jyoungyun jyoungyun deleted the onert/add_assertion_dconv_bprop branch July 29, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants