[circle2circle] Dredd test for fuse Add/Mul to FC and fold Mul #13444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add circle2circle dredd test for fuse Add/Mul to FC and fold Mul. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
shs-park
reviewed
Jul 16, 2024
Comment on lines
+67
to
+69
| Add(Net_Mul_FullyConnected_000 PASS fuse_mul_to_fullyconnected_weights fold_mul) | ||
| Add(Net_Mul_FullyConnected_001 PASS fuse_mul_to_fullyconnected_weights fold_mul) | ||
| Add(Net_Mul_FullyConnected_002 PASS fuse_mul_to_fullyconnected_weights fold_mul) |
There was a problem hiding this comment.
Unused parameters..!?
Suggested change
| Add(Net_Mul_FullyConnected_000 PASS fuse_mul_to_fullyconnected_weights fold_mul) | |
| Add(Net_Mul_FullyConnected_001 PASS fuse_mul_to_fullyconnected_weights fold_mul) | |
| Add(Net_Mul_FullyConnected_002 PASS fuse_mul_to_fullyconnected_weights fold_mul) | |
| Add(Net_Mul_FullyConnected_000 PASS fuse_mul_to_fullyconnected_weights) | |
| Add(Net_Mul_FullyConnected_001 PASS fuse_mul_to_fullyconnected_weights) | |
| Add(Net_Mul_FullyConnected_002 PASS fuse_mul_to_fullyconnected_weights) |
There was a problem hiding this comment.
fold_mul is an option needed to constant fold Mul op,
- this model has
FC(Mul(input,scale), weights, bias). fuse_mul_to_fullyconnected_weightswill convert toFC(input, Mul(weights, scale), bias)- dredd test cannot detect the difference as there exist same number of FC and Mul
fold_mulwill convert toFC(input, weights', bias)and we can detect absence ofMul
There was a problem hiding this comment.
I understand.
Thank you for the description =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add circle2circle dredd test for fuse Add/Mul to FC and fold Mul.