Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert-micro] Support Tanh float kernel #13220

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

SlavikMIPT
Copy link
Contributor

This commit supports Tanh float kernel.

ONE-DCO-1.0-Signed-off-by: Vyacheslav Bazhenov [email protected]

@SlavikMIPT SlavikMIPT requested a review from BalyshevArtem June 17, 2024 11:54
Comment on lines 34 to 35
return SISOOperation<T>(input_shape, input_data, output_shape, output_data,
[](T arg) -> T { return std::tanh(arg); });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use without SISOOpearation. Calling the lambda function for each element will slow down the execution of the kernel

This commit supports Tanh float kernel.

ONE-DCO-1.0-Signed-off-by: Vyacheslav Bazhenov <[email protected]>
@SlavikMIPT SlavikMIPT force-pushed the onert-micro-refactor/tanh branch from 17bec66 to d4675dc Compare June 18, 2024 09:17
@SlavikMIPT SlavikMIPT requested a review from BalyshevArtem June 18, 2024 09:41
Copy link
Contributor

@BalyshevArtem BalyshevArtem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BalyshevArtem BalyshevArtem merged commit 2f6f6b4 into Samsung:master Jun 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants