[onert-micro] Introduce Optimizers #13211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr introduces optimizers entities: SGD and Adam. ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
Torrero
previously approved these changes
Jun 17, 2024
| float epsilon = training_config.epsilon; | ||
| for (uint32_t i = 0; i < flat_size; ++i) | ||
| { | ||
| float exponent_corrected = exponent_data[i] / (1.f - beta_in_pow_batch); |
There was a problem hiding this comment.
Should check the division by zero?
chunseoklee
reviewed
Jun 17, 2024
| auto batches = static_cast<float>(training_config.batch_size); | ||
| for (uint32_t i = 0; i < flat_size; ++i) | ||
| { | ||
| const auto cur_val = calculated_data[i] / batches; |
There was a problem hiding this comment.
Suggested change
| const auto cur_val = calculated_data[i] / batches; | |
| const auto cur_val = calculated_data[i]; |
not sure but, this one is correct ?
There was a problem hiding this comment.
Done, thank you, you are right
Torrero
approved these changes
Jun 17, 2024
chunseoklee
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces optimizers entities: SGD and Adam.
for issue #12873
from draft: #13107
ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]