Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Create minmax dump file in handleSubgraphEnd #13170

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

hseok-oh
Copy link
Contributor

This commit updates MinMaxRecorder to create dump file in handleSubgraphEnd method, not in constructor.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]


Related issue: #12904 #13039
Draft: #13013

This commit updates MinMaxRecorder to create dump file in handleSubgraphEnd method, not in constructor.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Jun 12, 2024
@hseok-oh hseok-oh requested a review from a team June 12, 2024 07:04
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glistening glistening merged commit 313fb05 into Samsung:master Jun 13, 2024
9 checks passed
@hseok-oh hseok-oh deleted the create_file_on_end branch June 13, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants