[one-cmds] Implement get_arg_parser #13169
Merged
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a funciton that gets argument parser from the given target. ONE-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
mhs4670go
commented
Jun 12, 2024
| """ | ||
| if config_path is None: | ||
| return | ||
|
|
||
| parser = get_config_parser() | ||
| parser.read(config_path) | ||
|
|
||
| if not parser.has_section(section_to_parse) and quiet: |
There was a problem hiding this comment.
quiet arg is added because introducing [backend] section is not always exist for the backward compatability.
seanshpark
reviewed
Jun 12, 2024
| dir_path = os.path.dirname(os.path.realpath(__file__)) | ||
| # for python module naming convention | ||
| target_name = target.replace('-', '_') | ||
| command_schema_path = dir_path + f'/../../backends/command/{cmd}/{target_name}.py' |
There was a problem hiding this comment.
(optional) if there some kind of path provider then we can ask that provider for this kind of information.
There was a problem hiding this comment.
Yeah, that's good point. I'll revise that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a funciton that gets argument parser from the given target.
Draft: #13161
ONE-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com