Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert-micro] Add Softmax kernel #12742

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

BalyshevArtem
Copy link
Contributor

@BalyshevArtem BalyshevArtem commented Mar 12, 2024

This pr adds Softmax refactored kernel into onert-micro.

from draft #12426
for issue: #12427

ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]

This pr adds Softmax refactored kernel into onert-micro.

ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
@BalyshevArtem BalyshevArtem added the approval: 2 Require at least 2 approvals label Mar 12, 2024
// Compute result.
for (int c = 0; c < depth; ++c)
{
output_data[i * depth + c] = output_data[i * depth + c] / sum;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check division by zero?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, add checking

Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BalyshevArtem BalyshevArtem merged commit ef6299f into Samsung:master Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: 2 Require at least 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants