Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert-micro] Add FullyConnected kernel #12686

Merged

Conversation

BalyshevArtem
Copy link
Contributor

This pr adds FullyConnected kernel to onert-micro.

from draft #12426
for issue: #12427

ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]

@BalyshevArtem BalyshevArtem added the approval: 2 Require at least 2 approvals label Feb 22, 2024
Torrero
Torrero previously approved these changes Feb 27, 2024
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,23 @@
/*
* Copyright (c) 2021 Samsung Electronics Co., Ltd. All Rights Reserved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change 2021 to 2024?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since it was just copied from luci-interpreter, we don't have to change it, what do you think about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you

Artem Balyshev added 2 commits March 12, 2024 12:38
This pr adds FullyConnected kernel to onert-micro.

ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
@BalyshevArtem
Copy link
Contributor Author

@Torrero @SlavikMIPT
PTAL)

Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,23 @@
/*
* Copyright (c) 2021 Samsung Electronics Co., Ltd. All Rights Reserved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2021 Samsung Electronics Co., Ltd. All Rights Reserved
* Copyright (c) 2024 Samsung Electronics Co., Ltd. All Rights Reserved

@BalyshevArtem BalyshevArtem merged commit c783355 into Samsung:master Mar 12, 2024
4 checks passed
@BalyshevArtem BalyshevArtem deleted the add_fully_connected_onert_micro branch March 12, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: 2 Require at least 2 approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants