-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pota-quantization-value-test] Set right mode #12634
Conversation
This commit fixes the bug where the mode was not set properly. ONE-DCO-1.0-Signed-off-by: seongwoo <[email protected]>
|
@mhs4670go |
One of the tests that failed is
|
@Seunghui98 I've said the detail in the offline since it's a bit complicated to be explained by comments. But let me try as much as possible.
ONE/compiler/pota-quantization-value-test/compare_tensors_all.py Lines 36 to 53 in 7dea6ca
But, I mistakenly gave a wrong mode for some tests. Even though the test failed at first, the second run passed because the required output artifacts are generated from other test which is the one that I've mistakenly given. For example, this is the right test order. ./test.py --mode mixed_record_minmax
./test.py --mode mixed_quantization # it depends on the artifacts from `mixed_record_minmax`
./test.py --mode record_minmax
./test.py --mode quantization # it depends on the artifacts from `record_minmax` But, I mistakenly wrote tests like below. ./test.py --mode mixed_record_minmax
./test.py --mode quantization # WRONG!!
./test.py --mode record_minmax
./test.py --mode quantization Above second line failed because the But, second run passed because So, I fixed the wrong mode. I think this is because it is important to remove previously generated test artifacts before running the testing. |
Thank you for letting me know. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit fixes the bug where the mode was not set properly.
Related: #12526
ONE-DCO-1.0-Signed-off-by: seongwoo [email protected]