[onert-micro] Add execute part #12629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr adds execute entities part to the onert-micro ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
8 tasks
Torrero
reviewed
Feb 14, 2024
| float max_abs_error = 1.0e-5f); | ||
|
|
||
| template <typename T, typename U = T> | ||
| std::vector<U> checkSISOKernel(onert_micro::test_model::TestDataBase<T, U> *test_data_base) |
There was a problem hiding this comment.
Perhaps it would be better to combine the verification of kernels with one or two inputs (checkSISOKernel and checkTISOKernel) into one template function with a choice of the number of inputs
There was a problem hiding this comment.
Thank you for review! Yes, I agree, I moved this num of imputs as a functions checkKernel argument
Torrero
reviewed
Feb 14, 2024
|
|
||
| assert(input_product_scale >= 0); | ||
|
|
||
| return input_product_scale / static_cast<double>(output_scale); |
There was a problem hiding this comment.
I think it would be better to check this line for division by zero (output_scale)
There was a problem hiding this comment.
Done, thank you
Torrero
reviewed
Feb 14, 2024
| int32_t *activation_max) | ||
| { | ||
| auto quantize = [scale, zero_point](float x) { | ||
| return zero_point + static_cast<int32_t>(std::round(x / scale)); |
There was a problem hiding this comment.
I think it would be better to check this line for division by zero (scale)
There was a problem hiding this comment.
Done, thank you
SlavikMIPT
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds execute entities part to the onert-micro.
from draft #12426
for issue: #12427
ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]