[onert/train] Add PadLayer op to train backend #12535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds PadLayer op to train backend. ONE-DCO-1.0-Signed-off-by: Yongseop Kim <[email protected]>
|
PTAL @jyoungyun and @Samsung/one_onert |
zetwhite
reviewed
Jan 26, 2024
ragmani
reviewed
Jan 26, 2024
zetwhite
reviewed
Jan 29, 2024
zetwhite
reviewed
Jan 29, 2024
jyoungyun
reviewed
Jan 29, 2024
|
|
||
| // Note, this is pad with mode=`CONSTANT`: it doesn't support `REFLECT` and | ||
| // `SYMMETRIC` | ||
| class PadLayer : public ::onert::exec::train::ITrainableFunction |
There was a problem hiding this comment.
(Q) Is there any reason why you didn't inherit the PadLayer function of cpu kernel? If you inherit PadLayer from cpu, we can share private members and several functions including configure and run functions.
There was a problem hiding this comment.
That's a great point. Now I figure out!
|
PTAL all |
ragmani
reviewed
Jan 29, 2024
| @@ -35,6 +35,7 @@ using cpu::ops::getShape; | |||
| using cpu::ops::getNumberOfDimensions; | |||
| using cpu::ops::getNumberOfElements; | |||
| using cpu::ops::getSizeOfDimension; | |||
| using cpu::ops::ConstDataPtr; | |||
There was a problem hiding this comment.
Oops. You're right. I'll fix it.
|
PTAL all |
jyoungyun
approved these changes
Jan 29, 2024
| depad<float>(); | ||
| break; | ||
| case OperandType::QUANT_UINT8_ASYMM: | ||
| depad<uint8_t>(); |
| depad<uint8_t>(); | ||
| break; | ||
| case OperandType::QUANT_INT8_ASYMM: | ||
| depad<int8_t>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds PadLayer op to train backend.
ONE-DCO-1.0-Signed-off-by: Yongseop Kim [email protected]
for #12413
draft #12499