[DRAFT][tflchef] Support multiple subgraphs #12516
Conversation
BalyshevArtem
added
the
DRAFT
| /* | ||
| * Copyright (c) 2024 Samsung Electronics Co., Ltd. All Rights Reserved | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Add While operation for creating Net_DecomposedGru_000 #12319 (comment)
| const auto &inputs = *op->inputs(); | ||
|
|
||
| for (int input : inputs) | ||
| { | ||
| fill_tensor_to_import(input, import); | ||
| } |
There was a problem hiding this comment.
Added due to Less can have Const input as in example for #12319 (comment)
This draft adds supporting of multiple subgraphs and While operation. ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
BalyshevArtem
force-pushed
the
sup_multiple_subg
branch
from
0eb1989 to
eb1cd00
Compare
| operand->set_name(mio::tflite::tensor_name(tensor)); | ||
| operand->set_type(as_tflchef_type(tensor->type())); | ||
| operand->set_is_variable(tensor->is_variable()); | ||
| tflchef::Graph *graph; |
There was a problem hiding this comment.
graph will be uninitialized when n == 0
| if (shape_signature != nullptr) | ||
| { | ||
| tflchef::ShapeSignature *chef_shape_signature = operand->mutable_shape_signature(); | ||
| for (uint32_t j = 0; j < shape_signature->size(); ++j) |
There was a problem hiding this comment.
Q) why is this changed to j ?
There was a problem hiding this comment.
Because i is already used in above for loop:
for (uint32_t i = 0; i < tensors->size(); ++i)There was a problem hiding this comment.
Because i is already used in above for loop:
Then why is the loop before was OK but now nested?
There was a problem hiding this comment.
It's a bit hard to read the changes even with Hide whitespace
There was a problem hiding this comment.
Because i is already used in above for loop:
Then why is the loop before was OK but now nested?
Before changes this loop was nested too, and it was like shadows a local variable problem.
There was a problem hiding this comment.
Ah, got it, thanks! Can you fire a PR for this change in separate PR ?
|
@seanshpark, Can I split this draft into PRs? Or need more changes? |
Lets' go :) |
|
All merged, close it |
This draft adds supporting of multiple subgraphs and While operation.
for issue #12506
ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]