[onert-micro] Reduce duplicate code in binary kernels #12459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragmani
force-pushed
the
onert-micro/Reduce_DC_biaryops
branch
from
9ada010 to
1976f83
Compare
|
PTAL @chunseoklee |
chunseoklee
previously approved these changes
Jan 17, 2024
This commit reduces duplicate code in binary kernels.
- Introduce PALBinaryOpCommon.h that has common functions for binary kernels.
- Introduce binary function objects.
- Introduce `BinaryOp()` that unifies binary kernels without broadcast.
- Introduce `BroadcastBinaryOp4DSlow()` that unifies binary kernels with broadcast.
- Apply common functions for binary kernels.
- Introduce `areShapesEqual()` that unifies duplicated codes related to checking shapes.
ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
ragmani
dismissed stale reviews from chunseoklee and BalyshevArtem
via
88c6e17
ragmani
force-pushed
the
onert-micro/Reduce_DC_biaryops
branch
from
1976f83 to
88c6e17
Compare
|
Resolved conflict. |
chunseoklee
approved these changes
Jan 18, 2024
BalyshevArtem
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces duplicate code in binary kernels.
BinaryOp()that unifies binary kernels without broadcast.BroadcastBinaryOp4DSlow()that unifies binary kernels with broadcast.areShapesEqual()that unifies duplicated codes related to checking shapes.ONE-DCO-1.0-Signed-off-by: ragmani [email protected]
For #11744