[DRAFT] Support custom GRU #11840
Closed
[DRAFT] Support custom GRU #11840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 27, 2023 17:35
This commit adds optimization for While operation by checking condition graph and don't run it. ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
BalyshevArtem
added
the
DRAFT
BalyshevArtem
added
PR/NO TEST
BalyshevArtem
force-pushed
the
custom_gru
branch
from
f5d27fa to
e24b933
Compare
|
@BalyshevArtem Can we extend this to multiple GRU layer pattern like While-while-while-strideslice ? |
I think yes |
|
@BalyshevArtem Let's try to merge this PR into master. For this, we need to do :
|
2 tasks
seanshpark
reviewed
Dec 11, 2023
| @@ -46,6 +46,8 @@ class Module final | |||
| public: | |||
| void add(std::unique_ptr<loco::Graph> &&g); | |||
|
|
|||
| void remove(size_t idx); | |||
There was a problem hiding this comment.
Is it possible to make a copy of module without this idx subgraph and replace it?
seanshpark
reviewed
Dec 11, 2023
| @@ -34,6 +34,7 @@ class CircleOptimizer final | |||
| { | |||
| enum Algorithm | |||
| { | |||
| FuseUnrolledGRUAsCustomGRU, | |||
There was a problem hiding this comment.
plz add to bottom not on the top
There was a problem hiding this comment.
Actually, it is first draft, I will post new one with changes only in compiler part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft supports custom GRU, adds conversion in circle2cirlce as new pass, and adds new kernel in onert-micro
ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]