Skip to content

Commit

Permalink
[luci] Introduce the parent class method to luci::Pass
Browse files Browse the repository at this point in the history
This directive fixes a build break caused by a compiler error emitted when
compiling with -Werror=overloaded-virtual flag switched on. The error is about
the logo::Pass::run method being hidden by luci::Pass::run.

ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak <[email protected]>
  • Loading branch information
tomdol committed Jan 28, 2025
1 parent 3bc9824 commit 83e647c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions compiler/luci/pass/include/luci/ModulePass.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ namespace luci
class Pass : public logo::Pass
{
public:
// This directive prevents emitting a compiler erro triggered by -Werror=overloaded-virtual
using logo::Pass::run;
// Run module pass and return false if there was nothing changed
virtual bool run(luci::Module *) = 0;
};
Expand Down

0 comments on commit 83e647c

Please sign in to comment.