Apply suggestions from code review

Co-authored-by: Hyukjin Jeong <[email protected]> Co-authored-by: SaeHie Park <[email protected]>
Samsung · Jan 21, 2025 · 17c9dcf · 17c9dcf
1 parent ba9b962
commit 17c9dcf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/compiler/luci/pass/src/helpers/ArrayIndex.h b/compiler/luci/pass/src/helpers/ArrayIndex.h
@@ -23,7 +23,7 @@ namespace luci
 {
 
 /// @brief Index class for 4D tensor to calculate linear index from multi-dimensional indices.
-class Array4DIndex
+class Array4DIndex final
 {
 public:
   Array4DIndex(uint32_t d0, uint32_t d1, uint32_t d2, uint32_t d3);
@@ -37,7 +37,7 @@ class Array4DIndex
   /// @brief Get stride of the given axis.
   uint32_t stride(uint32_t axis) const;
 
-protected:
+private:
   uint32_t _dim[4];
   uint32_t _strides[4];
 };

diff --git a/compiler/luci/pass/src/helpers/ArrayIndex.test.cpp b/compiler/luci/pass/src/helpers/ArrayIndex.test.cpp
@@ -36,7 +36,7 @@ TEST(LuciPassHelpersArrayIndex, array_index_4d)
   EXPECT_EQ(idx(4, 3, 2, 1), 4 * 4 * 3 * 2 + 3 * 3 * 2 + 2 * 2 + 1);
 }
 
-TEST(LuciPassHelpersArrayIndex, array_index_4d_NEG)
+TEST(LuciPassHelpersArrayIndex, array_invalid_index_4d_NEG)
 {
   luci::Array4DIndex idx(4, 4, 3, 2);