[Toolchain] Uninstall toolchain #707
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -28,14 +28,15 @@ export class ToolchainNode extends vscode.TreeItem { | |||
| public readonly label: string, | |||
| public readonly collapsibleState: vscode.TreeItemCollapsibleState, | |||
| public readonly type: NodeType, | |||
| public readonly backend?: string, | |||
There was a problem hiding this comment.
Q. Any reason to assign backend as string | undefined? If you assign it as just the only string, we don't have to care about backend is undefined in ts.
There was a problem hiding this comment.
The backend is optional parameter so it can either have a value based on the type defined or its value can be undefined. However, when I use backend: string | undefined code, this value must be inputted. But NodeType.backend does not use backend string. So I use it as optional parameter.
There was a problem hiding this comment.
I understand your point.
This commit uninstalls the installed toolchain. After uninstalled the toolchain, the toolchain view will be updated automatically. ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
|
PTAL /cc @Samsung/one-vscode |
Um, ToolchainNode can't be separated for backend and toolchain. Because these item should be shared in this tree view. So it has the same root interface to share these one. I can separate the 3 class for parent and 2 children for backend and toolchain that inherit parent class. However, in most tree view example codes, it is designed to implement both parent and children nodes as one node. So I'm not sure if it really needs to be modified.... Anyway, I will consider about your suggestion more. :) |
|
Trial: #717 |
This commit uninstalls the installed toolchain.
After uninstalled the toolchain, the toolchain view will be updated
automatically.
ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun [email protected]