Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeTpu] Implement ConfigSetting #1727

Closed
wants to merge 2 commits into from
Closed

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Nov 1, 2023

This PR includes two commits about ConfigSettings.

NOTE They will be merged separately (not squash-merge)

From #1726

@dayo09 dayo09 changed the title [EdgeTpu] Separate ConfigObject's logic dependency [EdgeTpu] Implement ConfigSetting Nov 1, 2023
imsw0529 and others added 2 commits November 1, 2023 21:02
…ducing ConfigSetting (Samsung#1672)

* [EdgeTpu] Separate ConfigObject's logic dependent on Backend by introducing ConfigSetting

This commit separate ConfigObject's logic dependent on Backend by introducing ConfigSetting

- Introduce abstract class ConfigSetting for separate logic
- Introduce class OneConfigSetting extends ConfigSetting for ONE Backend logic
- Apply OneConfigSetting to ConfigObject
- Add Test code for ConfigSetting associated code

ONE-vscode-DCO-1.0-Signed-off-by: Seongwon Im <[email protected]>
Co-authored-by: SeungHyunH <[email protected]>
* [EdgeTpu] Introduce EdgeTpuConfigSetting

This commit introduce EdgeTpuConfigSetting that has ConfigObject logic for EdgeTpu Backend

- Introduce class EdgeTpuConfigSetting extends ConfigSetting for EdgeTpu Backend logic
- Apply EdgeTpuConfigSetting to ConfigObject
- Add Test code for EdgeTpuConfigSetting

ONE-vscode-DCO-1.0-Signed-off-by: Seongwon Im <[email protected]>
Co-authored-by: : SeungHyunH <[email protected]>
@dayo09 dayo09 added the 1 approval 1 approval required to be merged label Nov 1, 2023
@dayo09 dayo09 requested a review from a team November 1, 2023 12:06
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayo09 dayo09 added the DRAFT Something like playground label Nov 2, 2023
@dayo09 dayo09 closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval 1 approval required to be merged DRAFT Something like playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants