Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolchain] Change inference function name #1577

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

jyoungyun
Copy link
Collaborator

@jyoungyun jyoungyun commented Jun 4, 2023

This commit changes inference() to infer().

ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun [email protected]

Related issue: #1562

This commit changes inference() to infer().

ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun <[email protected]>
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark
Copy link
Contributor

@jyoungyun , changing API will break codes outside of this REPO if any.
It would be better to (1) add infer() (2) notify users to change codes before YY/MM (3) deprecate inference() at YY/MM.

I'll land this if you are sure changing this API is OK.

@jyoungyun
Copy link
Collaborator Author

jyoungyun commented Jun 8, 2023

@seanshpark

@jyoungyun , changing API will break codes outside of this REPO if any.
It would be better to (1) add infer() (2) notify users to change codes before YY/MM (3) deprecate inference() at YY/MM.

Fortunately, there is no use case for this api. I introduced this api last week (#1574). So I think it's better to change it quickly before someone uses it. :) Thank you!

@seanshpark seanshpark merged commit 49be6b6 into Samsung:main Jun 8, 2023
@jyoungyun jyoungyun deleted the rename_inference branch June 8, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants