Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toast message after search and navigating to the chat page of the searched user #285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: toast message after search and navigating to the chat page of the searched user #285

wants to merge 1 commit into from

Conversation

balaraju-nerati
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024

@balaraju-nerati is attempting to deploy a commit to the samarthkadam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Jun 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chat-box-jyxx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 5:47am

@SamarthKadam
Copy link
Owner

@Saigenix @Spiral-Memory Please review the code

@Spiral-Memory
Copy link
Collaborator

Hey @balaraju-nerati
Code looks fine to me, could you please attach a video showing how it works !

@balaraju-nerati
Copy link
Contributor Author

I already attached the working video @Spiral-Memory

@Spiral-Memory
Copy link
Collaborator

Got it, give me a minute !

@balaraju-nerati
Copy link
Contributor Author

Hey, @Spiral-Memory Please check it now.

@Spiral-Memory
Copy link
Collaborator

LGTM ! Good work @balaraju-nerati

@SamarthKadam
Copy link
Owner

ChatBox.-.Google.Chrome.2024-06-28.11-20-09.mp4

I see there is broken design. Fix it. I recomend create a new fork and only make the functionality changes with clean code

@balaraju-nerati balaraju-nerati force-pushed the bug/toast-message-after-search branch from ce1d9ec to 82b5d46 Compare July 1, 2024 13:25
@balaraju-nerati
Copy link
Contributor Author

Hey @SamarthKadam , The design broken due the last commit I have made. Sry for that. Now, I removed the last commit. Everything works fine. Please check once.

@balaraju-nerati
Copy link
Contributor Author

Hey, @SamarthKadam , Can you please look at this and merge the PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiral-Memory Spiral-Memory Spiral-Memory approved these changes

@Saigenix Saigenix Awaiting requested review from Saigenix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Showing {Username} added in the search function even after {Username} has been added
4 participants
@balaraju-nerati @SamarthKadam @Spiral-Memory @Saigenix