Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Online Presence Indicator to User Profiles #240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aakashsharma003
Copy link

@aakashsharma003 aakashsharma003 commented Jun 4, 2024

Implemented a User Online Status Indicator

Demo Video

demo2.mp4

Related Issue

Review Notes

Please review this PR and suggest any additional improvements or changes that could further enhance the application. Your feedback is valuable and appreciated.

Copy link

vercel bot commented Jun 4, 2024

@aakashsharma003 is attempting to deploy a commit to the samarthkadam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@SamarthKadam
Copy link
Owner

@aakashsharma003 What's the case with group. And did you test with all possible cases right?

@aakashsharma003
Copy link
Author

aakashsharma003 commented Jun 4, 2024

@SamarthKadam, do you want this feature for grps also, usually in Chat Apps I have'nt seen this kind of feature for grps like in whatsApp also ? Yp i handled all test cases like if user logged out, closes the tab, goes offline, etc in all cases it is working smoothly.

@aakashsharma003
Copy link
Author

@SamarthKadam , Firstly, please clarify exactly how you want to display the number of online users or any other relevant information in grps. Please make this clear so that I can finish it by tomorrow afternoon and commit it to the pull request for you to review. As you know, I've been working on this issue for more than a week now, and I want to resolve and finish it as soon as possible.

@SamarthKadam
Copy link
Owner

@aakashsharma003 Ok

@aakashsharma003
Copy link
Author

aakashsharma003 commented Jun 5, 2024

@SamarthKadam, So are you agree with only displaying users count for groups? Or you don't want a status for groups and just satisfied with only for users?

@SamarthKadam
Copy link
Owner

@aakashsharma003 well Im not able to see online feature
Screenshot (601)

@aakashsharma003
Copy link
Author

aakashsharma003 commented Jun 5, 2024

@SamarthKadam, refresh the page and try again sometimes it is updated in db bt doesn't re renders

@SamarthKadam
Copy link
Owner

@aakashsharma003 but that should be realtime using sockets right?

@aakashsharma003
Copy link
Author

aakashsharma003 commented Jun 7, 2024

Ys u are right, @SamarthKadam I will resolve this glitch and finish this issue by tomorrow evening. Just tell me is you want me add for grps also like how many number of users are online at that time in that grp or anything else pls mention how do you want to display if you want me to add this?

@SamarthKadam
Copy link
Owner

SamarthKadam commented Jun 8, 2024

@aakashsharma003 No need of that. Just make sure to have that online feature to be realtime

@aakashsharma003
Copy link
Author

Okay @SamarthKadam 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add User Online Status Indicator feature
2 participants