Created Dark mode #228
Open
Created Dark mode #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ayushmaanagarwal1211 is attempting to deploy a commit to the samarthkadam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hii i created the css according to me but if you don't like something please let me know . |
|
Hii @SamarthKadam Have a look |
|
Hii @SamarthKadam please review it |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -14,6 +14,7 @@ import NotFoundPage from './pages/404Page'; | |||
|
|
|||
| import Root,{loader as loadingAction} from './pages/Root'; | |||
| import Search from './pages/Search'; | |||
| import { DarkModeProvider } from './components/ToggleMode/DarkModeContext'; | |||
There was a problem hiding this comment.
Instead of having a specific DarkModeProvider, can we simply have a Theme provider that provides all the required colors? Based on the dark/light state, the colors will be displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a dark mode from that user can toggle light and dark mode .
closes : #222
bandicam.2024-06-01.19-52-15-033.mp4