Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Profile Image Upload Process with formatting option #137 #224

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ShristiSharan
Copy link

Enhanced the Image Uploading Process & made it smooth out

  1. Direct Navigating to local storage and uploading procedure
  2. Cropper added to adjust the frame wisely
  3. Quick reflection of the updated upload image.

Closes:#137

Reference of my change

image

image

image

and the change is quickly updated-
image

Copy link

vercel bot commented May 31, 2024

@ShristiSharan is attempting to deploy a commit to the samarthkadam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ShristiSharan
Copy link
Author

Kindly review my PR @SamarthKadam

@ShristiSharan
Copy link
Author

Kindly @SamarthKadam Merge this PR, enhanced

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chat-box-jyxx ❌ Failed (Inspect) Jun 18, 2024 8:46am

@SamarthKadam
Copy link
Owner

SamarthKadam commented Jun 4, 2024

@ShristiSharan make the edit icon little smaller and also make sure those buttons like upload and cancel make them synchronized with the rest of the buttons like update and reset. And also the crop button looks like a square. Make it look like a circle as our dp appears to be in circle

@ShristiSharan
Copy link
Author

@ShristiSharan make the edit icon little smaller and also make sure those buttons like upload and cancel make them synchronized with the rest of the buttons like update and reset. And also the crop button looks like a square. Make it look like a circle as our dp appears to be in circle

Sure I'll fix it!

@ShristiSharan
Copy link
Author

Fixed

  • Pen icon smaller
  • Modified Update and Cancel button synchronised with other buttons.
  • Cropper on Preview Image now appears to be circular highlighting how dp will finally look alike.

image

image

image

@SamarthKadam kindly merge this PR

@SamarthKadam
Copy link
Owner

@ShristiSharan why does it blur the background. Keep only the image editable not the whole screen

@ShristiSharan
Copy link
Author

@ShristiSharan why does it blur the background. Keep only the image editable not the whole screen

Ya!....changed it now, I mistook that.

image

@ShristiSharan
Copy link
Author

@SamarthKadam , kindly check it as the changes are done.

@ShristiSharan
Copy link
Author

the branch is updated!....kindly merge this PR @SamarthKadam

@ShristiSharan
Copy link
Author

@SamarthKadam could you please merge this PR! otherwise i'll have to keep updating my branch upon incoming pulls

@SamarthKadam
Copy link
Owner

@ShristiSharan Deployments have been failed have a look

@ShristiSharan
Copy link
Author

Done!!.... due to merge conflicts and @babel plugins it got erased.

@ShristiSharan
Copy link
Author

@SamarthKadam now to go... please check

@ShristiSharan
Copy link
Author

can you share the log? for deployment fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants