Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Showing {Username} added in the search function even after {Username} has been added #268

Open
balaraju-nerati opened this issue Jun 11, 2024 · 4 comments · May be fixed by #285
Open

Bug: Showing {Username} added in the search function even after {Username} has been added #268

balaraju-nerati opened this issue Jun 11, 2024 · 4 comments · May be fixed by #285
Assignees
@balaraju-nerati
Labels
gssoc level1

Comments

@balaraju-nerati
Copy link
Contributor

When user searches for the X person who is already added, showing added X person.

ChatBox.-.Google.Chrome.2024-06-11.20-01-52.mp4

Instead of showing the message, it should navigate to the chat of the person user searched.

@SamarthKadam I would like to work on this issue. Assign me this !
@Spiral-Memory
Copy link
Collaborator

Spiral-Memory commented Jun 12, 2024 •
edited
Loading

Hey @balaraju-nerati

Looks like a good find ! I am assigning it to you, but before you raise your PR, kindly let me know your approach in fixing it.

Also let me know that whether you are a gssoc contributor ?

@Spiral-Memory Spiral-Memory added gssoc and removed gssoc labels Jun 12, 2024
@balaraju-nerati
Copy link
Contributor Author

@Spiral-Memory Thankyou for assigning the issue. Yes I'm a gssoc'24 contributor. Please add the level of the issue too.

My approach -

When the user clicks the X person which he searched, it'll redirect to the chat of the X person if the person is already added and I'll remove the toast message.

@Spiral-Memory
Copy link
Collaborator

Spiral-Memory commented Jun 12, 2024 •
edited
Loading

Okay cool ! What about the user if they're not already added? If they're not, show a toast bar saying the user has been added like it is now and then redirect to his chat as well.

@balaraju-nerati balaraju-nerati linked a pull request Jun 26, 2024 that will close this issue
Open
@balaraju-nerati
Copy link
Contributor Author

Hey, @Spiral-Memory Can you check the PR I have raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balaraju-nerati balaraju-nerati

Labels
gssoc level1
Projects
None yet
Milestone
No milestone
2 participants
@Spiral-Memory @balaraju-nerati