-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schematic-230] propagate user ids as attribute to spans #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
reviewed
Jan 15, 2025
linglp
changed the title
[schematic-230] propagate user ids as attribute to all spans
[schematic-230] propagate user ids as attribute to spans
Jan 16, 2025
BryanFauble
reviewed
Jan 16, 2025
BryanFauble
reviewed
Jan 16, 2025
BryanFauble
reviewed
Jan 16, 2025
BryanFauble
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thomasyu888
reviewed
Jan 17, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When looking into a trace on Signoz, currently we have trace down user id in init span. This PR is to make sure that user id can be propagated to the top level span and also most of other span.
example screen shots that demonstrate the problem:
Here you could see "user id" contained a random string
And spans such as "query file view" do not contain a user id
Note: if a span has already ended we cannot add user id back to it. As an example,
ManifestGenerator::create_manifests
has two children, one isDataModelParser::parse_model
, and another one isManifestGenerator::create_single_manifest
. We could propagate user id back toManifestGenerator::create_manifests
, but notDataModelParser::parse_model
since this step happened before and ended by the time that the user id is available.Solution
Borrowed attribute propagation function here to propagate attributes from parent to child, and when the span ends, propagate attribute from back to parent.
Now the user id attribute can be shown in most of the spans.