[SCHEMATIC-210] Updates publish.yml for Test PyPi deployments (#1559)
#1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updates pypi publishing workflow * specify python version explicitly
|
Is there any documentation update needed to note the version update changes on release? I think we had a confluence page for the release process, contributing.md or the main Readme may also need updates |
thomasyu888
reviewed
Dec 17, 2024
BryanFauble
reviewed
Dec 17, 2024
thomasyu888
reviewed
Dec 17, 2024
There was a problem hiding this comment.
🔥 LGTM! Cool trick with the repository-url. I'll leave it to @linglp / @GiaJordan / @BryanFauble for final review.
BryanFauble
approved these changes
Dec 17, 2024
linglp
reviewed
Dec 17, 2024
linglp
reviewed
Dec 17, 2024
linglp
reviewed
Dec 17, 2024
linglp
approved these changes
Dec 17, 2024
GiaJordan
approved these changes
Dec 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates
publish.ymlto automatically publish releases to test pypi (on pre-release) and to pypi (on normal release). I also added "trusted publisher" relationships (OIDC) between this repo and both pypi repos so permanent access tokens are no longer required for the CI pipeline to run. While I was working on this, I was having issues with theupdate_version.pyfile and @thomasyu888 suggested deprecating it for simplicity so I did that. We will need to update the version inpyproject.tomlwhen publishing a release from now on (which is what the release instructions already said to do). I tested the workflow on both pre-releases and full releases and it behaved as expected. I subsequently deleted the release I made to pypi prod, but here is the release I made on test pypi.