[IT-3313] Explicitly create public buckets #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our bootstrap templates create public buckets to store cloudformation and lambda artifacts which is what we prefer. AWS changed the default account behavior to not allow creating public buckets[1]. To create public bucket we now much explicitly state that we want them to be public. This change does that. [1] https://repost.aws/questions/QUMcgxysOFRBmKIt9KRkYccg/api-s3-putbucketpolicy-access-denied-error-during-a-cloudformation-stack-creation
xschildw
approved these changes
Dec 4, 2023
zaro0508
added a commit
to Sage-Bionetworks-IT/organizations-infra
that referenced
this pull request
Dec 6, 2023
Bootstrap and setup basic infrastructure for the opendata AWS account. These are the base resources that we put on every account to allow us to easily manage the account using infrastructure as code. depends on Sage-Bionetworks/aws-infra#401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our bootstrap templates create public buckets to store cloudformation and lambda artifacts which is what we prefer. AWS changed the default account behavior to not allow creating public buckets[1]. To create public bucket we now must explicitly state that we want them to be public. This change does that.
[1] https://repost.aws/questions/QUMcgxysOFRBmKIt9KRkYccg/api-s3-putbucketpolicy-access-denied-error-during-a-cloudformation-stack-creation