Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IT-3815] Resolve vulnerability detected by dependabot #13

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 requested review from a team as code owners October 14, 2024 20:29
@zaro0508
Copy link
Contributor Author

@ConsoleCatzirl what do you suggest we do about this coveralls failures?

@ConsoleCatzirl
Copy link
Member

@zaro0508 there are some coveralls settings at https://coveralls.io/github/Sage-Bionetworks-IT/cfn-cr-sc-product-provider/settings for when to return a check failure (Im pretty sure you should have admin access there, it relies on your github permissions). my intention is for coveralls to only be advisory, not to fail the check.

the "threshold" settings were blank, which should mean no failures for lack of coverage, but I've set them to explicitly allow zero coverage without failure.

@zaro0508 zaro0508 merged commit 4c4aaa8 into Sage-Bionetworks-IT:master Oct 18, 2024
6 of 7 checks passed
zaro0508 added a commit to Sage-Bionetworks-IT/organizations-infra that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants