Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-3508 feed account history #478

Merged
merged 15 commits into from
Nov 4, 2024
Merged

DEV-3508 feed account history #478

merged 15 commits into from
Nov 4, 2024

Conversation

MickStanciu
Copy link
Collaborator

@MickStanciu MickStanciu commented Oct 15, 2024

Summary

Adds a new feed that is incremental

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

Copy link

gitguardian bot commented Oct 16, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@MickStanciu MickStanciu marked this pull request as ready for review October 16, 2024 02:12
@MickStanciu MickStanciu requested a review from a team as a code owner October 16, 2024 02:12
@MickStanciu MickStanciu requested review from BarryMacchicken, HarryTranAU and sc-gv and removed request for BarryMacchicken October 16, 2024 02:12
@MickStanciu MickStanciu self-assigned this Oct 16, 2024
@MickStanciu MickStanciu removed the request for review from HarryTranAU October 31, 2024 00:06
HarryTranAU
HarryTranAU previously approved these changes Oct 31, 2024
@MickStanciu MickStanciu merged commit 4cfe95c into main Nov 4, 2024
14 checks passed
@MickStanciu MickStanciu deleted the DEV-3508-feed-history branch November 4, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants