ENHANCED: Handle C++ functions in doc files' #1229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
man/doc2tex.pl
Outdated
| @@ -327,6 +341,7 @@ | |||
| prolog_id_cont(CL), | |||
| { atom_codes(Name, [C0|CL]) }. | |||
|
|
|||
| prolog_id_cont(_) --> "(", !, { fail }. | |||
There was a problem hiding this comment.
Why is this? ( is not a Prolog id continue character, no?
There was a problem hiding this comment.
This is a left-over from when I was using your original ordering of tr//2 rules.
I ended up re-ordering them, so that the identifier(...) stuff is done before detecting an atom -- otherwise, things such as PlTerm::unify_blob() weren't handled correctly.
It appears to be unnecessary (and a cut-fail isn't good style either).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cxxfuncref currently is the same as \cfuncref. It was useful for debugging
doc2tex.pl; and it's possible that the definition will change in future.This change depends on SWI-Prolog/packages-ltx2htm#5