ENHANCED: HTTP Unix daemon now also works without certificate and key. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important to launch servers that rely exclusively on SNI, where clients that do not support SNI should be rejected. Certificates and keys can be added with ssl_add_certificate_key/3, in a suitable hook that is yet to be added to HTTP or the SSL plugin.
|
If I see things correctly, this doesn't give us back the default certificate in the same way. If we want to have that we need to use ssl_server_create_hook/3, no? It gets a little hacky to find out that the context has no certificate though. Even if we do find out, we must now load the certificate as an unprivileged user instead of Well, I think we can hack something acceptable using |
|
Merged after changing http_daemon/1 to be a viable alternative to be called by applications with suitable defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler way to implement #76.
After applying this pull request, all that remains to accommodate SWISH (using
server.crtandserver.keyas default parameters) and servers with multiple certificates is a new hook that lets us set additional certificates (using the newssl_add_certificate_key/3) in a strategic place, by providing access to the server's SSL context after it is created.Please see #77 for the discussion and naming suggestion.