Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that depend on the BCI repo for the LTSS container #711

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

dirkmueller
Copy link
Member

We have the LTSS container on a service pack still in general support, so a container-specific exclusion rather than merely a version based exclusion is needed.

Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but I think handling this in a decorator would be more obvious as that's where we generally handle skipifs

We have the LTSS container on a service pack still in general support,
so a container-specific exclusion rather than merely a version based
exclusion is needed.
@dirkmueller dirkmueller force-pushed the skip_ltss_container_checks branch from 7859e5a to a238309 Compare December 20, 2024 11:11
@dirkmueller
Copy link
Member Author

LGTM in general, but I think handling this in a decorator would be more obvious as that's where we generally handle skipifs

it is a lot of repetition imho. anyhow, updated.

@dirkmueller dirkmueller requested a review from dcermak December 20, 2024 11:12
@m-dati
Copy link

m-dati commented Dec 20, 2024

LGTM, but some CI checks fail

Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we also need to fix the remaining test (metadata for instance is red as well)

@dirkmueller
Copy link
Member Author

dirkmueller commented Dec 20, 2024

Well, we also need to fix the remaining test (metadata for instance is red as well)

did you check the error?

Command '['docker', 'pull', 'registry.suse.com/suse/ltss/sle15.5/bci-base:15.5']' returned non-zero exit status 1

That's because this PR is not being merged. metadata checks are green in openqa, the only thing blocking it from being released is this PR. see https://openqa.suse.de/tests/16265656/file/bci_logs-junit_base_.xml and https://openqa.suse.de/tests/16265656/file/bci_logs-junit_metadata_.xml and https://openqa.suse.de/tests/16265656/file/bci_logs-junit_all_.xml

@dirkmueller dirkmueller requested a review from dcermak December 20, 2024 20:18
@dirkmueller
Copy link
Member Author

moving ahead, we need to get the container out..

@dirkmueller dirkmueller merged commit 3b947b4 into main Dec 21, 2024
132 of 138 checks passed
@dirkmueller dirkmueller deleted the skip_ltss_container_checks branch December 21, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants