-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests that depend on the BCI repo for the LTSS container #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, but I think handling this in a decorator would be more obvious as that's where we generally handle skipifs
We have the LTSS container on a service pack still in general support, so a container-specific exclusion rather than merely a version based exclusion is needed.
7859e5a
to
a238309
Compare
it is a lot of repetition imho. anyhow, updated. |
LGTM, but some CI checks fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we also need to fix the remaining test (metadata for instance is red as well)
did you check the error?
That's because this PR is not being merged. metadata checks are green in openqa, the only thing blocking it from being released is this PR. see https://openqa.suse.de/tests/16265656/file/bci_logs-junit_base_.xml and https://openqa.suse.de/tests/16265656/file/bci_logs-junit_metadata_.xml and https://openqa.suse.de/tests/16265656/file/bci_logs-junit_all_.xml |
moving ahead, we need to get the container out.. |
We have the LTSS container on a service pack still in general support, so a container-specific exclusion rather than merely a version based exclusion is needed.