Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edusign app/sp updates for latest version #227

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

kushaldas
Copy link
Contributor

This has tested in edusign test servers.

@kushaldas kushaldas changed the base branch from main to testing December 16, 2024 12:54
manifests/edusign/app.pp Dismissed Show dismissed Hide dismissed
manifests/edusign/app.pp Fixed Show resolved Hide resolved
manifests/edusign/app.pp Fixed Show fixed Hide fixed
manifests/edusign/app.pp Fixed Show fixed Hide fixed
manifests/edusign/validator.pp Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@SpaceFarmer SpaceFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we fix the puppet-lint suggestion about changing to singel quotes.

manifests/edusign/app.pp Fixed Show resolved Hide resolved
@SpaceFarmer SpaceFarmer self-requested a review December 16, 2024 15:03
Copy link
Contributor

@SpaceFarmer SpaceFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushaldas kushaldas merged commit be81ef8 into testing Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants