Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing a new docker class without network namespace #120

Merged
merged 28 commits into from
Jan 19, 2024

Conversation

theseal
Copy link
Contributor

@theseal theseal commented Jan 19, 2024

Should be safe to merge to main and testing on a Friday (I need to make another branch which depends on this merge) since its mostly introduce new stuff.

Tested the branch on a machine running the old class on Debian 12 and run without any changes.

See https://wiki.sunet.se/display/sunetops/sunet%3A%3Adockerhost2 for a migration path and caveats.

Copy link
Contributor

@mikaelfrykholm mikaelfrykholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mickenordin mickenordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

Copy link
Contributor

@eest eest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theseal theseal merged commit 2b4329a into main Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants